Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include current version in update check explicitly #2967

Merged
merged 2 commits into from Jan 17, 2017

Conversation

@dbkr
Copy link
Member

dbkr commented Jan 17, 2017

Hopefully fix #2847

Hopefully fix #2847
Copy link
Member

richvdh left a comment

So what's this for? are you planning on something server-side which will make use of this?

Anyway, LGTM modulo stupid questions.

// it anywhere (apart from the User-Agent) so it's up to us. We could
// (and previously did) just use the User-Agent, but this doesn't
// rely on NSURLConnection setting the User-Agent to what we expect,
// and also acts as a convenient cache-buster between versions.

This comment has been minimized.

Copy link
@richvdh

richvdh Jan 17, 2017

Member

surely a cache-buster which depends on the current local version doesn't help?

This comment has been minimized.

Copy link
@dbkr

dbkr Jan 17, 2017

Author Member

Yeah, was trying to say that it would make sure a new version of the app did a new hit. Have clarified the comment.

@richvdh richvdh assigned dbkr and unassigned richvdh Jan 17, 2017
@dbkr

This comment has been minimized.

Copy link
Member Author

dbkr commented Jan 17, 2017

Yep, currently it uses the value in the User-Agent so I'll migrate it over to use this.

@dbkr dbkr merged commit 6257019 into develop Jan 17, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.