Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redeploy script to keep old bundles #2969

Merged
merged 1 commit into from Jan 17, 2017

Conversation

@richvdh
Copy link
Member

richvdh commented Jan 17, 2017

... so that people using old versions of the master chunk can still load other
webpack chunks.

... so that people using old versions of the master chunk can still load other
webpack chunks.
Copy link
Member

dbkr left a comment

Otherwise lgtm

@@ -179,18 +257,34 @@ def on_receive_jenkins_poke():
To this location."
)
)
parser.add_argument(
"--test", dest="tarball_uri", help=(

This comment has been minimized.

Copy link
@dbkr

dbkr Jan 17, 2017

Member

Is this arg supposed to be called '--test'?

@dbkr dbkr assigned richvdh and unassigned dbkr Jan 17, 2017
@richvdh

This comment has been minimized.

Copy link
Member Author

richvdh commented Jan 17, 2017

@richvdh richvdh merged commit 641a5c2 into develop Jan 17, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@dbkr

This comment has been minimized.

Copy link
Member

dbkr commented Jan 17, 2017

Conclusion: it is just for testing right now, but the code to do this deploying in the production env is still in the pipeline.

@richvdh richvdh deleted the rav/keep_old_bundles branch Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.