Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to electron desktop notifs #2994

Merged
merged 1 commit into from Jan 19, 2017

Conversation

@dbkr
Copy link
Member

dbkr commented Jan 19, 2017

Merge the notification part of #2960

  • Show and focus the window when the notification is clicked,
    rather than just restoring it.
  • Implement requestNotificationPermission and return a resolved
    promise (although in practice it should never be called)
Merge the notification part of #2960

 * Show and focus the window when the notification is clicked,
   rather than just restoring it.
 * Implement requestNotificationPermission and return a resolved
   promise (although in practice it should never be called)
@richvdh richvdh merged commit 686a3c6 into develop Jan 19, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.