Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only recalculate favicon if it changes #3067

Merged
merged 2 commits into from Jan 26, 2017

Conversation

@ara4n
Copy link
Member

ara4n commented Jan 25, 2017

this is a brute force fix to lots of emitted sync events causing tonnes of:

"WebPlatform.js:58 Failed to set badge count: Error setting badge. Message: Too many badges requests in queue."

it's an open question as to why we are seeing so many sync events, though, which seem to outnumber the number of /sync responses.

@richvdh

This comment has been minimized.

Copy link
Member

richvdh commented Jan 25, 2017

I'd like to punt this to @dbkr since I think he's more familiar with me on this

@richvdh richvdh assigned dbkr and unassigned richvdh Jan 25, 2017
@dbkr
dbkr approved these changes Jan 26, 2017
@dbkr dbkr merged commit f9db7f0 into develop Jan 26, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@richvdh

This comment has been minimized.

Copy link
Member

richvdh commented Jan 26, 2017

this is broken; reverting

richvdh added a commit that referenced this pull request Jan 26, 2017
This reverts commit f9db7f0, reversing
changes made to 71b149d.

This caused `number is not defined`
Half-Shot added a commit to Half-Shot/riot-web that referenced this pull request Feb 9, 2017
…badge-spam"

This reverts commit f9db7f0, reversing
changes made to 71b149d.

This caused `number is not defined`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.