Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS for a support box in login #3081

Merged
merged 1 commit into from Jan 27, 2017

Conversation

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Jan 27, 2017

This box can be used to provide useful hints during registration/login.

This box can be used to provide useful hints during registration/login.
@lukebarnard1 lukebarnard1 requested a review from dbkr Jan 27, 2017
text-align: center;
font-size: 13px;
margin-top: 0px;
opacity: 0.7;

This comment has been minimized.

Copy link
@dbkr

dbkr Jan 27, 2017

Member

Surprising - isn't this going to make the text semi-transparent?

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 Jan 27, 2017

Author Contributor

Yep, it's the same trick done elsewhere in that file (and other places).

This comment has been minimized.

Copy link
@dbkr

dbkr Jan 27, 2017

Member

Ah ok - I've seen a few places where the CSS is using transparency apparently to achieve a particular colour rather than just making it that colour, but let's follow the current style for now.

@dbkr
dbkr approved these changes Jan 27, 2017
@lukebarnard1 lukebarnard1 merged commit 6374526 into develop Jan 27, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@lukebarnard1 lukebarnard1 deleted the luke/css-login-support branch Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.