Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jenkins build #3105

Merged
merged 1 commit into from Feb 1, 2017

Conversation

@richvdh
Copy link
Member

richvdh commented Feb 1, 2017

Do npm install on js-sdk rather than npm run build, which will hopefully
mean that browserify gets installed before we try to run it.

The README says we should use npm install for the react-sdk too, so let's do
that, and bring the travis and jenkins builds into sync with the README.

Do `npm install` on js-sdk rather than `npm run build`, which will hopefully
mean that `browserify` gets installed before we try to run it.

The README says we should use `npm install` for the react-sdk too, so let's do
that, and bring the travis and jenkins builds into sync with the README.
@dbkr
dbkr approved these changes Feb 1, 2017
@dbkr dbkr merged commit 0db97b8 into develop Feb 1, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@richvdh richvdh deleted the rav/fix_jenkins_build branch Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.