Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle icons with width > height #3110

Merged
merged 1 commit into from Feb 2, 2017

Conversation

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Feb 2, 2017

Icons with width > height will now only assume a max-height of 100% as opposed to a height of 100%. This is so they don't overflow the width of 300px.

Before:
2017-02-02-113238_518x528_scrot

After:
2017-02-02-113252_407x408_scrot

Icons with width > height will now only assume a max-height of 100% as opposed to a height of 100%. This is so they don't overflow the width of 300px.
@lukebarnard1 lukebarnard1 requested a review from dbkr Feb 2, 2017
@dbkr
dbkr approved these changes Feb 2, 2017
@dbkr dbkr merged commit 00c2608 into develop Feb 2, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.