Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More aggressive rageshake log culling #3311

Merged
merged 2 commits into from Feb 23, 2017

Conversation

@richvdh
Copy link
Member

richvdh commented Feb 23, 2017

Also bump the client-side timeout on the upload from 3 mins to 5 mins, to see
if it helps people on slower connections.

Also bump the client-side timeout on the upload from 3 mins to 5 mins, to see
if it helps people on slower connections.
});
size += lines.length;
if (size > MAX_LOG_SIZE) {
if (i > 0 && size + lines.length > MAX_LOG_SIZE) {

This comment has been minimized.

Copy link
@Kegsay

Kegsay Feb 23, 2017

Contributor

Warrants a one-liner to explain:

// only add more than 1 log if they won't take us over the MAX_LOG_SIZE
@Kegsay

This comment has been minimized.

Copy link
Contributor

Kegsay commented Feb 23, 2017

Other than comment, LGTM!

@richvdh richvdh merged commit bb4d8ee into develop Feb 23, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@richvdh richvdh deleted the rav/rageshake_culling branch May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.