Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose notification option for username/MXID #3334

Merged
merged 2 commits into from Mar 2, 2017

Conversation

@turt2live
Copy link
Member

turt2live commented Feb 27, 2017

For those unfortunate people that get pinged constantly.

Fixes #2773

For those unfortunate people that get pinged constantly.
// Messages containing user's username (localpart/MXID)
".m.rule.contains_user_name": new VectorPushRuleDefinition({
kind: "override",
description: "Messages containing my username",

This comment has been minimized.

Copy link
@ara4n

ara4n Feb 27, 2017

Member

i'd call it 'user name' for consistency with elsewhere. otherwise this lgtm - thanks!

This comment has been minimized.

Copy link
@turt2live

turt2live Feb 27, 2017

Author Member

fixed

@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Feb 28, 2017

@dbkr this change is fine by me; if you can review it it'd be appreciated

@dbkr
dbkr approved these changes Mar 2, 2017
@dbkr dbkr merged commit c6da4d9 into vector-im:develop Mar 2, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.