Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set padding-bottom: 0px for .mx_Dialog spinner #3351

Merged
merged 2 commits into from Mar 3, 2017

Conversation

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Mar 2, 2017

This was causing #3226

This was causing #3226
@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Mar 3, 2017

it seems very strange it was ever special-casing the left edge. why wouldn't this be padding: 0px?

@ara4n ara4n assigned lukebarnard1 and unassigned ara4n Mar 3, 2017
@lukebarnard1

This comment has been minimized.

Copy link
Contributor Author

lukebarnard1 commented Mar 3, 2017

@ara4n padding: 0px would make far more sense, and works in practice. Strange indeed!

@lukebarnard1 lukebarnard1 assigned ara4n and unassigned lukebarnard1 Mar 3, 2017
@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Mar 3, 2017

lgtm!

@lukebarnard1 lukebarnard1 merged commit b1f14ba into develop Mar 3, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.