Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix people section again #3458

Merged
merged 2 commits into from Mar 27, 2017

Conversation

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Mar 17, 2017

  • Alter CSS due to removed mx_RoomDropTarget_avatar. The avatar was removed because it didn't particularly add anything and we needed space for "Drop here to tag as direct chat", which is quite long.
  • Use guessAndSetDMRoom as a convenience method for guessing the DM member and setting the state.
  • Do evil hacks to make DNDRoomTile do dragging of RoomTiles to and from the People section. Dragging a DM to and from Rooms/Favourites/Low Priority now works as one would expect. This is still not ideal however because edge cases exist where you have more than one tag set and then you drag a DM from "Favourites" to "Rooms" and the tile ends up in "People". This would require setting multiple tags, and breaks the 1-1 mapping between tags and sections even further. Ultimately the UI needs a rework. Fixes #3449

Requires matrix-org/matrix-react-sdk#761
2017-03-17-121812_229x425_scrot

 - Alter CSS due to removed mx_RoomDropTarget_avatar. The avatar was removed because it didn't particularly add anything and we needed space for "Drop here to tag as direct chat", which is quite long.
 - Use guessAndSetDMRoom as a convenience method for guessing the DM member and setting the state.
 - Do evil hacks to make DNDRoomTile do dragging of RoomTiles to and from the People section. Dragging a DM to and from Rooms/Favourites/Low Priority now works as one would expect. This is still not ideal however because edge cases exist where you have more than one tag set and then you drag a DM from "Favourites" to "Rooms" and the tile ends up in "People". This would require setting multiple tags, and breaks the 1-1 mapping between tags and sections even further. Ultimately the UI needs a rework.
Copy link
Member

dbkr left a comment

See comment on matrix-org/matrix-react-sdk#761 but otherwise looks fine

@dbkr dbkr assigned lukebarnard1 and unassigned dbkr Mar 17, 2017
@lukebarnard1 lukebarnard1 assigned dbkr and unassigned lukebarnard1 Mar 27, 2017
@dbkr
dbkr approved these changes Mar 27, 2017
@dbkr dbkr assigned lukebarnard1 and unassigned dbkr Mar 27, 2017
@lukebarnard1 lukebarnard1 merged commit 8b50ed8 into develop Mar 27, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.