Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dark theme invert inconsistent across browsers #3479

Merged

Conversation

@t3chguy
Copy link
Collaborator

t3chguy commented Mar 20, 2017

fixes #3433

-webkit-filter::invert (generated) seems to default to invert(1)
whereas filter::invert is documented to default to invert(0) (no inversion)

t3chguy added 2 commits Mar 20, 2017
…with webkit-filter/filter

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy changed the title dark theme invert inconsistent accross browsers dark theme invert inconsistent across browsers Mar 20, 2017
@t3chguy

This comment has been minimized.

Copy link
Collaborator Author

t3chguy commented Mar 25, 2017

This also fixes a CSS Warning (invalid property value) and also fixes non-inverted code blocks

Before
screenshot_20170325_132220

After (matches the styling of Electron app)
screenshot_20170325_132236

@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Mar 25, 2017

awesome! sorry for missing the PR - great catch; thanks :)

@ara4n ara4n merged commit f413416 into vector-im:develop Mar 25, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.