Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show phone number as target for email notifs #3530

Merged
merged 2 commits into from Mar 28, 2017

Conversation

@dbkr
Copy link
Member

dbkr commented Mar 28, 2017

Fixes #3518

Copy link
Contributor

lukebarnard1 left a comment

LGTM otherwise

return true;
}
}).length == 0) {
const emailThreepids = this.props.threepids.filter((tp) => tp.medium == "email");

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 Mar 28, 2017

Contributor

Nit: ===

}).length == 0) {
const emailThreepids = this.props.threepids.filter((tp) => tp.medium == "email");
let emailNotificationsRow;
if (emailThreepids.length == 0) {

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 Mar 28, 2017

Contributor

and again

@dbkr dbkr merged commit 2480831 into develop Mar 28, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.