Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not assume getTs will return comparable integer #3536

Merged
merged 1 commit into from Mar 29, 2017

Conversation

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Mar 29, 2017

In the worst case, tsOfNewestEvent will return MAX_SAFE_INTEGER, instead of undefined, as may be the case of some events that were redacted and persisted in indexdb before changes were made to how events are redacted locally. (The important change is that events are now not stripped of their origin_server_ts).

Fixes #3529.

Fixes #3529. In the worst case, tsOfNewestEvent will return MAX_SAFE_INTEGER, instead of undefined, as may be the case of some events that were redacted and persisted in indexDB before changes were made to how events are redacted locally. (The important change is that events are now not stripped of their `origin_server_ts`).
@lukebarnard1 lukebarnard1 requested a review from dbkr Mar 29, 2017
@dbkr
dbkr approved these changes Mar 29, 2017
@dbkr dbkr merged commit e248a7f into develop Mar 29, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.