Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ImageView Download functionality #3640

Merged
merged 1 commit into from Apr 22, 2017

Conversation

@t3chguy
Copy link
Collaborator

t3chguy commented Apr 17, 2017

depends on matrix-org/matrix-react-sdk#802

fixes #2778 and #2970

Notes:
Right clicking "Download this file" and clicking what comes up in Electron lets you send it to Browser/Image Viewer and obviously "Open in new tab" works in browsers. Though this will not work for Encrypted Images in [only] Electron, but will in browsers which support data URIs.

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy force-pushed the t3chguy:t3chguy/lightbox_download_button branch from 9cce90a to cc7a585 Apr 17, 2017
@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Apr 22, 2017

Whilst I've got used to the 'download' button actually loading things in a new tab, agreed this is a sensible fix - thanks.

@ara4n ara4n merged commit 523b315 into vector-im:develop Apr 22, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Apr 22, 2017

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.