Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rageshake: fix race when collecting logs #3644

Merged
merged 1 commit into from Apr 18, 2017

Conversation

@richvdh
Copy link
Member

richvdh commented Apr 18, 2017

apparently it's possible for your indexeddb transaction to complete in the
background, so that the oncomplete handler is never called. Make sure that
the oncomplete handler is set before doing the work.

*apparently* it's possible for your indexeddb transaction to complete in the
background, so that the `oncomplete` handler is never called. Make sure that
the oncomplete handler is set *before* doing the work.
@dbkr dbkr self-assigned this Apr 18, 2017
@dbkr
dbkr approved these changes Apr 18, 2017
@dbkr dbkr assigned richvdh and unassigned dbkr Apr 18, 2017
@richvdh richvdh merged commit fa132d3 into develop Apr 18, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@richvdh richvdh deleted the rav/fix_rageshake_race branch Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.