Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress updates for rageshake uploads #3648

merged 3 commits into from Apr 18, 2017


Copy link

richvdh commented Apr 18, 2017

There are a few phases to doing a rageshake, so it's nice to get some feedback.

Also, load submit-rageshake asynchronously.

Also, fix some callbacks to check the unmounted guard.

Builds on top of #3646. The actual changes are 7449137, 43c2d87 and a51898c.

dbkr approved these changes Apr 18, 2017
Copy link

dbkr left a comment

-1 for none of the statuses being, "Reticulating Splines", but OK.

@dbkr dbkr assigned richvdh and unassigned dbkr Apr 18, 2017
@richvdh richvdh force-pushed the rav/rageshake_progress branch from a51898c to 2590730 Apr 18, 2017
@richvdh richvdh merged commit 66a4738 into develop Apr 18, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
@richvdh richvdh deleted the rav/rageshake_progress branch Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.