Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

styling for spoilerized access token view in Settings #3651

Merged
merged 2 commits into from Apr 22, 2017

Conversation

@t3chguy
Copy link
Collaborator

t3chguy commented Apr 18, 2017

Copied header from the other scss file in that dir

improves matrix-org/matrix-react-sdk#806
word break forced because access tokens are long and ugly so wouldn't want to scroll for ages to get to the end of it.

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Apr 22, 2017

the right place to put this is in _UserSettings.scss - the idea is that there's a strict 1:1 mapping of React component .js to the associated .scss file, if you can shift it over please :)

NOTE TO SELF
1:1 mapping between react component to scss file.
Makes sense...

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@ara4n ara4n merged commit 8a6283f into vector-im:develop Apr 22, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Apr 22, 2017

thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.