Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent long room names/topics from pushing UI of the screen #3721

Merged
merged 1 commit into from Apr 24, 2017

Conversation

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Apr 24, 2017

This was causing the "save" button in RoomSettings to be obscured when room names were set to long strings without spaces

Fixes #1729

This was causing the "save" button in RoomSettings to be obscured when room names were set to long strings without spaces

Fixes #1729
@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Apr 24, 2017

is there a reason to do it as overflow rather than letting long words break mid-word?

@lukebarnard1

This comment has been minimized.

Copy link
Contributor Author

lukebarnard1 commented Apr 24, 2017

@ara4n basically I couldn't wrangle the flex: #1729 (comment)

@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Apr 24, 2017

better than nothing for now then :) lgtm

@ara4n ara4n merged commit 7957eeb into develop Apr 24, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.