Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change redact -> remove to improve clarity #3722

Merged
merged 2 commits into from May 28, 2017

Conversation

@turt2live
Copy link
Member

turt2live commented Apr 24, 2017

Addresses #2814

Non-technical users may not understand what 'redact' means and can more easily understand what 'Remove' does. See discussion on #2814 for more information.

Paired with: matrix-org/matrix-react-sdk#831

Addresses #2814

Non-technical users may not understand what 'redact' means and can more easily understand what 'Remove' does. See discussion on #2814 for more information.

Signed-off-by: Travis Ralston <travpc@gmail.com>
@t3chguy

This comment has been minimized.

Copy link
Collaborator

t3chguy commented Apr 24, 2017

Remove is slightly less clear in its actual action, since the actual content of the message is not removed. (Still visible to admins and whatnot)

@t3chguy

This comment has been minimized.

Copy link
Collaborator

t3chguy commented Apr 24, 2017

Personally #2814 (comment) makes more sense but since there are now modal confirmations is it really needed to make the button less "correct"

#2814 (comment)

@turt2live

This comment has been minimized.

Copy link
Member Author

turt2live commented Apr 24, 2017

After reading the discussion on #2814 it seems like people prefer 'Remove' or 'Delete', as those are terms used almost unanimously in chat clients/other software. 'Retract' to me still feels like something that non-technical users wouldn't understand the implications of, or have to think about what the action is before doing it. Having the user think less about what the button could do is important to not have small roadblocks that could result in someone not using Riot.

Granted, the actual implementation is still different from the label. As mentioned in #2814, most users aren't going to care that their message is still legible somewhere, or that it's possible that it doesn't actually remove it from everywhere. They just wanted to delete something they said.

@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Apr 24, 2017

My personal preference here has always been 'delete', with 'hide' used for (in future) hiding messages just from the reader.

But the problem with 'delete' and 'remove' is that it implies the permanence which you normally get from computers when you ask them to remove something - which obviously isn't the case here. I also agree that 'retract' is clumsy, and that 'redact' is useless for most people. 'recall' makes people think of evil Outlook, but it's at least a familiar model...

Suggestions welcome for alternatives. I'll ask around too.

@turt2live

This comment has been minimized.

Copy link
Member Author

turt2live commented May 5, 2017

Has a decision been made on 'delete' or 'remove' (or other)? Last update was an ask for feedback, and unfortunately it looks like few comments made it this far.

@turt2live

This comment has been minimized.

Copy link
Member Author

turt2live commented May 28, 2017

@ara4n

Has a decision been made on 'delete' or 'remove' (or other)? Last update was an ask for feedback, and unfortunately it looks like few comments made it this far.

@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented May 28, 2017

i'm going to make an exec decision to go with 'remove', given it feels somewhat less final than 'delete'.

@ara4n ara4n merged commit fabae2f into vector-im:develop May 28, 2017
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.