Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added default_federate property #3849

Merged

Conversation

@psaavedra
Copy link
Contributor

psaavedra commented May 8, 2017

This change allows change the default value for m.federate value during the create action. Useful for enviroments where you prefer m.federate = False as default choice for the created rooms (see related PR).

This PR is embraces the following SPEC: https://docs.google.com/document/d/14zqsbwl5KKil-bB8w2HMhidBVmFkP9Q7EQKFwKIIfZc/edit#heading=h.eipip5qhqo0d

Other PR in synapse and matrix-react-sdk and synapse are envolved

Signed-off-by: Pablo Saavedra psaavedra@igalia.com

Related PR:

Edited by Michael to match what the PR actually entails rather than the entire movement that it began as

@t3chguy

This comment has been minimized.

Copy link
Collaborator

t3chguy commented Aug 2, 2017

I'm interested in reviving this PR. It needs to be made against the develop branch (and using it as a base)

Just needs origin/develop merging back into it to update the base branch

@t3chguy t3chguy changed the base branch from master to develop Aug 2, 2017
t3chguy added 6 commits Aug 2, 2017
…lt_federate_by_settings
…ult_federate_by_settings
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
…ult_federate_by_settings
…ult_federate_by_settings
@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Oct 4, 2017

sorry this has been stuck for so long, and thanks for submitting it. matrix-org/matrix-react-sdk#868 has more details; will merge once 868 lands

@lukebarnard1 lukebarnard1 merged commit 508ff4f into vector-im:develop Oct 11, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.