Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Added default_federate property #3849
Conversation
This was referenced May 8, 2017
|
I'm interested in reviving this PR. Just needs origin/develop merging back into it to update the base branch |
t3chguy
changed the base branch from
master
to
develop
Aug 2, 2017
t3chguy
added some commits
Aug 2, 2017
|
sorry this has been stuck for so long, and thanks for submitting it. matrix-org/matrix-react-sdk#868 has more details; will merge once 868 lands |
lukebarnard1
merged commit 508ff4f
into
vector-im:develop
Oct 11, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
psaavedra commentedMay 8, 2017
•
edited by t3chguy
This change allows change the default value for
m.federatevalue during the create action. Useful for enviroments where you preferm.federate = Falseasdefaultchoice for the created rooms (see related PR).This PR is embraces the following SPEC: https://docs.google.com/document/d/14zqsbwl5KKil-bB8w2HMhidBVmFkP9Q7EQKFwKIIfZc/edit#heading=h.eipip5qhqo0dOther PR in synapse and matrix-react-sdk and synapse are envolvedSigned-off-by: Pablo Saavedra psaavedra@igalia.com
Related PR:
Edited by Michael to match what the PR actually entails rather than the entire movement that it began as