Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move electron -> electron_app because npm smart #3877

Merged
merged 1 commit into from May 10, 2017

Conversation

@t3chguy
Copy link
Collaborator

t3chguy commented May 10, 2017

npm is "smart" enough to try and install our electron wrapper as a module
instead of the actual electron package. With no way to ignore directories.
I'd like to think of this as temporary, until I get to rip apart riot-web
and riot-electron

$ npm i electron
npm ERR! Refusing to install package with name "riot-web" under a package
npm ERR! also called "riot-web". Did you name your project the same
npm ERR! as the dependency you're installing?

Signed-off-by: Michael Telatynski 7t3chguy@gmail.com

…dule

instead of the actual electron package. With no way to ignore directories.
I'd like to think of this as temporary, until I get to rip apart riot-web
and riot-electron

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@dbkr
dbkr approved these changes May 10, 2017
@dbkr dbkr merged commit e67e891 into develop May 10, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@t3chguy t3chguy deleted the t3chguy/electron_install_fix branch May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.