Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron Tray Improvements #3909

Merged
merged 8 commits into from May 19, 2017

Conversation

@t3chguy
Copy link
Collaborator

t3chguy commented May 13, 2017

supersedes #3835
thus for #3554

  • make Electron Tray icon mimic the Favicon (has notifications count badge)

  • make Electron Tray Tooltip mimic document.title (has info like [offline])

  • add electron_app to .gitignore, missed it when renaming

  • tidy up tray.js

  • move Favico.js stuff into VectorBasePlatform as now Electron uses it too, no point doing the generation in the other process as that just means the electron package will have two copies of the library.

Screenshots below shows favicon still working on WebPlatform, and the tray icon behaviour too:
screenshot 22
screenshot_20170513_132630

t3chguy added 5 commits May 13, 2017
DRY: moved Favicon stuff into the base platform

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented May 16, 2017

someone was just asking for this in HQ... @dbkr, feel free to reassign this if you don't have PR review bandwidth

@SiwyPL

This comment has been minimized.

Copy link

SiwyPL commented May 16, 2017

Hey @t3chguy can you make the notification count badge showing also in Windows taskbar icon like this?:

przechwytywanie

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy

This comment has been minimized.

Copy link
Collaborator Author

t3chguy commented May 17, 2017

@SiwyPL spróbuję
(I'll try it)

t3chguy added 2 commits May 17, 2017
LETS MAKE IT CLEAR WE ARE NEEDY AND WANT ATTENTION

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
also improve favicon updating to not change if we're same as previous
not sure how intensive the nativeImage stuff is but cheap efficiency

For FLASH FLASH I moved the setBadgeCount stuff RPC -> IPC
should be more reliable now, its in electron-main
Win only:
if mainWindow is set and is not in focus make it FLASH
clear flash if notification gets cleared elsewhere
debounce focus handler so we don't set a million of them
if the app is backgrounded a while

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy

This comment has been minimized.

Copy link
Collaborator Author

t3chguy commented May 17, 2017

@SiwyPL now it'll both flash and show you number of notifications, you wanted it to be obvious right :P?
(only flash until you focus the window again)
screenshot 41

@SiwyPL

This comment has been minimized.

Copy link

SiwyPL commented May 17, 2017

oh maaan thanks, that was quick

@dbkr
dbkr approved these changes May 19, 2017
Copy link
Member

dbkr left a comment

This looks super awesome, thanks! Sorry for not getting to review this sooner.

@dbkr dbkr merged commit a9b5282 into develop May 19, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@t3chguy

This comment has been minimized.

Copy link
Collaborator Author

t3chguy commented May 19, 2017

No worries @dbkr - clear how busy you've been recently :)

@t3chguy t3chguy deleted the t3chguy/favicon_improvements branch Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.