Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show redact in context menu only if has PL to/sent message #3925

Merged
merged 6 commits into from May 30, 2017

Conversation

@t3chguy
Copy link
Collaborator

t3chguy commented May 16, 2017

t3chguy added 4 commits May 16, 2017
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@lukebarnard1

This comment has been minimized.

Copy link
Contributor

lukebarnard1 commented May 17, 2017

This may indeed work but I'm wary of inspecting js-sdk state in render. In theory we should only ever query state or props. In this case we should consider whether the result of maySendRedactionForEvent will change whilst this component is visible. I could imagine that it would change if the user's power levels change.

t3chguy added 2 commits May 29, 2017
…e button if PL increases later.

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy

This comment has been minimized.

Copy link
Collaborator Author

t3chguy commented May 29, 2017

@lukebarnard1 how about now, it'll re-check on a PL change

@lukebarnard1 lukebarnard1 merged commit 543f4ef into develop May 30, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@t3chguy t3chguy deleted the t3chguy/show_redact_if_can branch Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.