Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to deflakify joining test #3956

Merged
merged 3 commits into from May 18, 2017

Conversation

@richvdh
Copy link
Member

richvdh commented May 18, 2017

Give the client a bit longer to get started.

I also pulled in some mock-request updates from js-sdk, and did a few more updates (which I'll probably backport), though none of that turned out to be strictly necessary.

richvdh added 3 commits May 18, 2017
Just copy-and-paste the updated version from js-sdk in here.
attempt to make the logging a bit more comprehensible
give the client a bit longer to get started.
Copy link
Contributor

lukebarnard1 left a comment

LGTM apart from tiny thing

if (idx >= 0) {
console.log("Aborting HTTP request: %s %s", opts.method, opts.uri);
console.log("Aborting HTTP request: %s %s", opts.method,
opts.uri);

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 May 18, 2017

Contributor

This doesn't seem necessary unless it was to reduce line length?

This comment has been minimized.

Copy link
@richvdh

richvdh May 18, 2017

Author Member

oh, it just came with the c&p from js-sdk. Where it probably did happen to reduce line length.

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 May 18, 2017

Contributor

ah ok

@richvdh richvdh merged commit 4d60d44 into develop May 18, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@richvdh richvdh deleted the rav/deflakify branch May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.