Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More riot-web test deflakification #3966

Merged
merged 1 commit into from May 19, 2017

Conversation

@richvdh
Copy link
Member

richvdh commented May 19, 2017

Two changes:

  1. wait longer for /sync to arrive in the loading tests, via an
    expectAndAwaitSync method.

  2. matrix-org/matrix-react-sdk#773 made it possible for
    MatrixChat to not show its syncing spinner despite loading being
    false. Update awaitSyncingSpinner accordingly, so that it doesn't fail
    when it happens to check MatrixChat at just taht moment.

Two changes:

1. wait longer for /sync to arrive in the loading tests, via an
   `expectAndAwaitSync` method.

2. matrix-org/matrix-react-sdk#773 made it possible for
   MatrixChat to not show its syncing spinner despite `loading` being
   false. Update `awaitSyncingSpinner` accordingly, so that it doesn't fail
   when it happens to check MatrixChat at just taht moment.
@richvdh richvdh merged commit 0a920df into develop May 19, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@richvdh richvdh deleted the rav/more_deflakification branch May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.