Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy electron files, they weren't pwetty #3993

Merged
merged 5 commits into from May 26, 2017

Conversation

@t3chguy
Copy link
Collaborator

t3chguy commented May 22, 2017

no logic changes
mostly readability, rest is pleasing the Gods of ESLint

t3chguy added 4 commits May 22, 2017
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
);
} else if (process.platform == 'win32') {
electron.autoUpdater.setFeedURL(update_base_url + 'win32/' + process.arch + '/');
`${updateBaseUrl}macos/?localVersion=${encodeURIComponent(electron.app.getVersion())}`);

This comment has been minimized.

Copy link
@ara4n

ara4n May 26, 2017

Member

i'm not sure this is a legibility improvement tbh...

@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented May 26, 2017

lgtm, i think

@ara4n ara4n merged commit 1bcdf31 into develop May 26, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@t3chguy t3chguy deleted the t3chguy/tidy_electron_files branch Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.