Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-launch support [Electron] #4012

Merged
merged 8 commits into from May 30, 2017

Conversation

@t3chguy
Copy link
Collaborator

t3chguy commented May 24, 2017

settings are sorta generic, probably reusable for proxy settings

cross-platform start with system log in support

depends on matrix-org/matrix-react-sdk/pull/920

NEEDS MORE TESTING NEEDS REVIEW

  • tested on Windows 10
  • tested on Mac OS 10.10.5
  • tested on KDE Neon (Ubuntu 16.04)

edit does not start hidden on Linux, do not merge until this is addressed.
edit2: workaround fitted and upstream bug reported electron/electron/issues/9621

settings are sorta generic, probably reusable for proxy settings

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy changed the title auto-launch support, ux =checkbox in UserSettings[Electron] auto-launch support [Electron] May 24, 2017
t3chguy added 2 commits May 29, 2017
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
t3chguy added 5 commits May 30, 2017
…-web into t3chguy/electron_settings
(which has hit me once)

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@@ -45,47 +46,6 @@ const INITIAL_UPDATE_DELAY_MS = 30 * 1000;
let mainWindow = null;
let appQuitting = false;

function safeOpenURL(target) {

This comment has been minimized.

Copy link
@ara4n

ara4n May 30, 2017

Member

um, why is this all being deleted?

This comment has been minimized.

Copy link
@t3chguy

t3chguy May 30, 2017

Author Collaborator

#4021 moved it to another file, #3993 brought it back (duplicated) because of a bad merge
this removes it once again, it is in the other file now.

@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented May 30, 2017

lgtm other one confusion

@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented May 30, 2017

lgtm

@ara4n ara4n merged commit 448c107 into develop May 30, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@t3chguy t3chguy deleted the t3chguy/electron_settings branch Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.