Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add moar context menus [Electron] #4021

Merged
merged 2 commits into from May 25, 2017

Conversation

@t3chguy
Copy link
Collaborator

t3chguy commented May 25, 2017

split all webContents.on's into the new file, keeping main cleaner
add handlers for editable fields, with Cut Copy Paste Undo Redo etc
add Copy Image feature to all images, working on not only the download
buttons now

fixes #3156

screenshot 87

Signed-off-by: Michael Telatynski 7t3chguy@gmail.com

t3chguy added 2 commits May 25, 2017
add handlers for editable fields, with Cut Copy Paste Undo Redo etc
add Copy Image feature to all images, working on not only the download
buttons now

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@dbkr
dbkr approved these changes May 25, 2017
Copy link
Member

dbkr left a comment

Have already fed this back on #riot-dev, but ftr it's better to separate things like this into one commit that moves things to the new file and then another that adds to the new file.

@dbkr dbkr merged commit 5ccab39 into develop May 25, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@t3chguy

This comment has been minimized.

Copy link
Collaborator Author

t3chguy commented May 25, 2017

@dbkr will remember for next time, sorry

@t3chguy t3chguy deleted the t3chguy/electron_context_menus branch Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.