Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an input field's background color in dark theme #4053

Merged
merged 1 commit into from May 27, 2017

Conversation

@ollieh
Copy link
Contributor

ollieh commented May 27, 2017

#3927

Changed it to look like this:
screenshot_2017-05-27_15-14-29

This is consistent with the "Create new room" dialog, which also has a dark text input box. I noticed their font sizes are slightly different (14px vs 15px), should this be the case?

Copy link
Collaborator

t3chguy left a comment

LGTM

@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented May 27, 2017

whilst the BG is right, i'm a bit worried that the border of the text input and the font colour may not be consistent with the rest of the app?

@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented May 27, 2017

actually, i see that's ok on checking the CSS now. thanks!

@ara4n ara4n merged commit 29653e8 into vector-im:develop May 27, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.