Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting of networks within a protocol based on name #4054

Merged
merged 1 commit into from Oct 14, 2017

Conversation

@ollieh
Copy link
Contributor

ollieh commented May 27, 2017

#3771

Now it looks like this:
screenshot_2017-05-27_17-27-39

@ollieh ollieh force-pushed the ollieh:issues/3771 branch from 53b040c to d28efa0 May 27, 2017
@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented May 27, 2017

iirc "matrix.org" is intended to be the parent heading, then all the things with icons are subpoints of matrix.org, just badly shown as such.

@ollieh

This comment has been minimized.

Copy link
Contributor Author

ollieh commented May 27, 2017

Will there ever be multiple headings, or can I just stick it at the top?

@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented May 27, 2017

It's possible for custom-homeserver folk:
image

(and for others who define their settings correctly... somehow).

@ollieh

This comment has been minimized.

Copy link
Contributor Author

ollieh commented May 27, 2017

Ooh, that makes things rather trickier.

@ollieh

This comment has been minimized.

Copy link
Contributor Author

ollieh commented May 27, 2017

Changed it to just sort between headings, although it feels a bit complicated. I guess it could be simplified if it did this while it was adding them, but I wanted to keep the sorting logic separated in case I changed the behaviour.

Signed-off-by: Oliver Hunt <oliver@hunt.bz>
@ollieh ollieh force-pushed the ollieh:issues/3771 branch from 9fe3b13 to 16357a9 May 27, 2017
@ollieh

This comment has been minimized.

Copy link
Contributor Author

ollieh commented May 27, 2017

Figured out how the list was being constructed and put the sorting logic in there, much neater!
screenshot_2017-05-27_19-12-25

@ollieh ollieh changed the title Sorting of networks based on icon and text Sorting of networks within a protocol based on name May 27, 2017
@t3chguy

This comment has been minimized.

Copy link
Collaborator

t3chguy commented May 27, 2017

looks much better than the initial pr diff

@lukebarnard1

This comment has been minimized.

Copy link
Contributor

lukebarnard1 commented Jun 19, 2017

Removing my assignment for now as I don't actually know if we want Gitter all the way down there. @ara4n's input would be appreciated.

@uhoreg uhoreg referenced this pull request Jun 30, 2017
@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Oct 14, 2017

sorry for missing this months ago - if you need my input please assign it to me... the alphabetised list looks good to me.

@ara4n ara4n merged commit 6f81960 into vector-im:develop Oct 14, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.