Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piwik Analytics #4056

Merged
merged 13 commits into from May 30, 2017

Conversation

@t3chguy
Copy link
Collaborator

t3chguy commented May 27, 2017

[IN PROGRESS] [NEEDS REVIEW]

Comments about analytics/tracking here welcome.
Especially useful would be ones which help me spot useful things to track to understand userflow better.

At initial this is extremely basic but provides a rock solid base that anything can hook into to send events to Piwik.

dep[matrix-org/matrix-react-sdk/pull/948]

Build available at https://riot.ovh/builds/piwik
Room/User data is <redacted> so feel free to log in and help test analytics.

nts: based on 6a7daaf

t3chguy added 3 commits May 27, 2017
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy referenced this pull request May 27, 2017
@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented May 28, 2017

this is already better than what we had with GA, so i'd feel inclined to merge it asap and see how the data looks. I wonder if we should provide an option to disable analytics other than via DNT. (Also I wonder if DNT is the right thing to use, given we're not tracking the user cross-site, which is I think what DNT tries to avoid...).

Can you put some examples in config.json.sample of what the piwik config should look like?

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy

This comment has been minimized.

Copy link
Collaborator Author

t3chguy commented May 28, 2017

@ara4n
I will swap out DNT for a localStorage flag toggled in User Settings
also gonna make the statistics more user readable e.g RightPanel -> Right Panel
and will have to change the page tracking to track the url in a redacted fashion so that things like transition graphs (useful for user flow?) work instead of them thinking each page is just a reload of the previous

Sample config added

t3chguy added 3 commits May 28, 2017
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@ArchangeGabriel

This comment has been minimized.

Copy link

ArchangeGabriel commented May 28, 2017

Also DNT wouldn’t work for Electron, right?

@t3chguy

This comment has been minimized.

Copy link
Collaborator Author

t3chguy commented May 28, 2017

@ArchangeGabriel good point, maybe my subconcious wanted to force analytics on people :P

@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented May 28, 2017

ok, will hold off until DNT is switched for synced settings.

@t3chguy

This comment has been minimized.

Copy link
Collaborator Author

t3chguy commented May 29, 2017

t3chguy added 2 commits May 29, 2017
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
as it now relies on SDKConfig

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy force-pushed the t3chguy/piwik branch from d1cf7a2 to 3e7b738 May 29, 2017
t3chguy added 4 commits May 29, 2017
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
when it tries file://

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented May 30, 2017

@t3chguy lmk when i can review/merge. this doesn't have to have all possible metrics present from the outset - would be much more useful to just get it into the RC, which we're planning on cutting today (Tuesday)

@t3chguy

This comment has been minimized.

Copy link
Collaborator Author

t3chguy commented May 30, 2017

@ara4n ready for review :D

@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented May 30, 2017

lgtm

@ara4n ara4n merged commit 60a56d0 into develop May 30, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@t3chguy t3chguy deleted the t3chguy/piwik branch Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.