Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate src/vector #4119

Merged
merged 4 commits into from May 31, 2017

Conversation

@Kegsay
Copy link
Contributor

Kegsay commented May 31, 2017

Including src/vector/platform.

Kegsay added 2 commits May 31, 2017
@Kegsay Kegsay assigned ara4n and richvdh and unassigned ara4n May 31, 2017
@Kegsay Kegsay requested a review from richvdh May 31, 2017
@Kegsay

This comment has been minimized.

Copy link
Contributor Author

Kegsay commented May 31, 2017

Integration tests failed when GH was down:

The command "scripts/fetch-develop.deps.sh" failed and exited with 1 during .
@@ -19,6 +19,7 @@ limitations under the License.

import VectorBasePlatform from './VectorBasePlatform';
import dis from 'matrix-react-sdk/lib/dispatcher';
import _t from 'matrix-react-sdk/lib/languageHandler';

This comment has been minimized.

Copy link
@t3chguy

t3chguy May 31, 2017

Collaborator

Should it not be import { _t } from 'matrix-react-sdk/lib/languageHandler'; ?

This comment has been minimized.

Copy link
@Kegsay

Kegsay May 31, 2017

Author Contributor

Yep, typically I had only tested this on WebPlatform which was the only one to import correctly. Thanks.

This comment has been minimized.

Copy link
@t3chguy

t3chguy May 31, 2017

Collaborator

np :)

@@ -18,6 +18,8 @@ limitations under the License.
*/

import BasePlatform from 'matrix-react-sdk/lib/BasePlatform';
import _t from 'matrix-react-sdk/lib/languageHandler';

This comment has been minimized.

Copy link
@t3chguy

t3chguy May 31, 2017

Collaborator

same Q as above

This comment has been minimized.

Copy link
@Kegsay

Kegsay May 31, 2017

Author Contributor

Yep, typically I had only tested this on WebPlatform which was the only one to import correctly. Thanks.

@t3chguy

This comment has been minimized.

Copy link
Collaborator

t3chguy commented May 31, 2017

Apart from Q, LGTM

@ara4n ara4n merged commit bac5ae8 into develop May 31, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.