Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron flashFrame was way too annoying #4128

Merged
merged 1 commit into from May 31, 2017

Conversation

@t3chguy
Copy link
Collaborator

t3chguy commented May 31, 2017

depends on matrix-org/matrix-react-sdk/pull/985

so that flashFrame is only triggered by loud notifications
it started really annoying me

win32 check is optional just there so we're not attaching pointless handlers

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented May 31, 2017

lgtm

@ara4n ara4n merged commit d988eb5 into develop May 31, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@t3chguy t3chguy deleted the t3chguy/electron_flash branch Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.