Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add border on hover for code blocks #4259

Merged
merged 2 commits into from Jun 18, 2017

Conversation

@ollieh
Copy link
Contributor

ollieh commented Jun 9, 2017

The border for non hovered codeblocks is the same colour as the background, and there so the content doesn't move when the border is added.

Signed-off-by: Oliver Hunt <oliver@hunt.bz>
@@ -345,6 +345,11 @@ limitations under the License.
}
.mx_EventTile_body pre {
position: relative;
border: 1px solid #f8f8f8;

This comment has been minimized.

Copy link
@ara4n

ara4n Jun 9, 2017

Member

hm, surely this should be a $ variable so that it themes correctly?

@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Jun 9, 2017

one comment, otherwise lgtm. Also, you might want to just consider 1px solid transparent for the null case

Signed-off-by: Oliver Hunt <oliver@hunt.bz>
@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Jun 18, 2017

thanks

@ara4n ara4n merged commit 4afec6f into vector-im:develop Jun 18, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dbkr added a commit that referenced this pull request Jun 19, 2017
Add border on hover for code blocks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.