Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that we handle stored mx_last_room_id correctly #4292

Merged
merged 1 commit into from Jun 14, 2017

Conversation

@richvdh
Copy link
Member

richvdh commented Jun 13, 2017

  • Do we show the last room correctly on resume?
  • Do we show the home page if we have no last room?
  • If we follow a login link, and re-log-in, do we correctly vape the mx_last_room_id (#4283)

This will fail until the corresponding matrix-react-sdk PR lands.

 * Do we show the last room correctly on resume?
 * Do we show the home page if we have no last room?
 * If we follow a login link, and re-log-in, do we correctly vape the
   mx_last_room_id (#4283)
Copy link
Contributor

lukebarnard1 left a comment

LGTM otherwise

also, the tests are passing on travis....

@@ -271,9 +245,30 @@ describe('loading:', function () {
localStorage.setItem("mx_is_url", "http://localhost" );
localStorage.setItem("mx_access_token", "access_token");
localStorage.setItem("mx_user_id", "@me:localhost");
localStorage.setItem("mx_last_room_id", "!last_room:id");

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 Jun 14, 2017

Contributor

I'm not sure I like the fact that these tests rely on each other... Could this be moved to the start of the next test?

This comment has been minimized.

Copy link
@richvdh

richvdh Jun 14, 2017

Author Member

this is a beforeEach, not a test?

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 Jun 14, 2017

Contributor

Oh! That's fine then :)

@lukebarnard1 lukebarnard1 assigned richvdh and unassigned lukebarnard1 Jun 14, 2017
@richvdh

This comment has been minimized.

Copy link
Member Author

richvdh commented Jun 14, 2017

also, the tests are passing on travis....

Ah yes. That's because of the magic where we use the same-named branch of react-sdk.

@richvdh richvdh merged commit d7fb009 into develop Jun 14, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@richvdh richvdh deleted the rav/clear_storage_on_login branch Jun 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.