Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove onload simulator from loading test #4314

Merged
merged 1 commit into from Jun 15, 2017

Conversation

@richvdh
Copy link
Member

richvdh commented Jun 14, 2017

This used to exist to reproduce the functionality in the window.onload handler
in vector/index.js -- which got removed in 8b0390f. Having it here is confusing
at best.

This used to exist to reproduce the functionality in the window.onload handler
in vector/index.js -- which got removed in 31915db. Having it here is confusing
at best.
@lukebarnard1

This comment has been minimized.

Copy link
Contributor

lukebarnard1 commented Jun 15, 2017

I don't think that's the correct commit that you're referencing...

@lukebarnard1 lukebarnard1 assigned richvdh and unassigned lukebarnard1 Jun 15, 2017
@richvdh

This comment has been minimized.

Copy link
Member Author

richvdh commented Jun 15, 2017

Fixed the commit ref.

@richvdh richvdh merged commit 2c8c26a into develop Jun 15, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@richvdh richvdh deleted the rav/remove_onload_simulator branch Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.