Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak tests to match updates to matrixchat #4325

Merged
merged 1 commit into from Jun 19, 2017

Conversation

@richvdh
Copy link
Member

richvdh commented Jun 15, 2017

Update the vector-web tests to handle the refactorathon that happened in matrix-org/matrix-react-sdk#1102.

Mostly this is just making it look at the view state rather than the individual boolean flags.

One other tweak merits explanation: we now implement the initial couldn't-register-as-guest login with an explicit switch to the LOGIN view, which means that the URL gets updated to #/login.

@lukebarnard1 lukebarnard1 assigned richvdh and unassigned lukebarnard1 Jun 16, 2017
Mostly this is just making it look at the `view` state rather than the
individual boolean flags.

One other tweak merits explanation: we now implement the initial
couldn't-register-as-guest login with an explicit switch to the LOGIN view,
which means that the URL gets updated to #/login.

We also now need to give the login panel a bit longer to appear.
@richvdh richvdh force-pushed the rav/refactor_matrixclient_states branch from 24ad1af to 641f20a Jun 19, 2017
@richvdh richvdh merged commit 98f8be4 into develop Jun 19, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@richvdh richvdh deleted the rav/refactor_matrixclient_states branch Jun 19, 2017
richvdh added a commit that referenced this pull request Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.