Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onLoadCompleted is now onTokenLoginCompleted #4335

Merged
merged 3 commits into from Jun 19, 2017

Conversation

@richvdh
Copy link
Member

richvdh commented Jun 16, 2017

@@ -47,7 +47,7 @@ describe('loading:', function () {
// the mounted MatrixChat
let matrixChat;

// a promise which resolves when the MatrixChat calls onLoadCompleted
// a promise which resolves when the MatrixChat calls onTokenLoginCompleted

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 Jun 16, 2017

Contributor

But it only calls onTokenLoginCompleted if the token login was a success. Should this test not just fail? Unless it logins in with a token explicitly?

This comment has been minimized.

Copy link
@richvdh

richvdh Jun 16, 2017

Author Member

which test?

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 Jun 16, 2017

Contributor

Ah only the token login test uses this promise. Could you rename the promise in that case? 😇

@lukebarnard1 lukebarnard1 assigned richvdh and unassigned lukebarnard1 Jun 16, 2017
@richvdh richvdh merged commit 563d1dc into develop Jun 19, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@richvdh richvdh deleted the rav/fix_token_redirect branch Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.