Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test 'return-to-app' functionality #4352

Merged
merged 1 commit into from Jun 19, 2017

Conversation

@richvdh
Copy link
Member

richvdh commented Jun 19, 2017

Add a test for the 'log in as user' functionality, as well as the 'return to
app' functionality.

Add a test for the 'log in as user' functionality, as well as the 'return to
app' functionality.
@richvdh

This comment has been minimized.

Copy link
Member Author

richvdh commented Jun 19, 2017

(This is failing because matrix-org/matrix-react-sdk#1116 hasn't landed yet)

// we simulate a click on the 'login' button by firing off
// the relevant dispatch.
//
// XXX: is it an anti-pattern to access the react-sdk's

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 Jun 19, 2017

Contributor

We don't really need to test the login button before every test, I think it'd be best to use start_login given that this is the beforeEach. If we had a dedicated integration test for the flow where the user clicks on "Login", logs in etc., then it'd be better to find the button and simulate a click.

@richvdh richvdh merged commit f6cbb70 into develop Jun 19, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
@richvdh richvdh deleted the rav/test_return_to_app branch Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.