Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicit convert to nativeImage to stabilise trayIcon on Windows [Electron] #4355

Merged
merged 1 commit into from Jun 21, 2017

Conversation

@t3chguy
Copy link
Collaborator

t3chguy commented Jun 19, 2017

fixes that trayIcon.setImage(newFavicon); sometimes threw:

(node:10936) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 3): TypeError: Error processing argument at index 0, conversion failure from C:\Users\t3chg\AppData\Local\Temp\win32_riot_icon.ico

because even though the API claims it accepts a string sometimes it just fails to want to causing a desync between the number of Unread rooms and the number of Unread rooms in the Favicon.
Also pre-build the defaultIcon for reuse

Signed-off-by: Michael Telatynski 7t3chguy@gmail.com

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@dbkr
dbkr approved these changes Jun 21, 2017
Copy link
Member

dbkr left a comment

Mmm, nice how it will only read ICOs from a file :/

@dbkr dbkr merged commit 7d3f75e into develop Jun 21, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@t3chguy t3chguy deleted the t3chguy/electron/windows_icon_instability branch Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.