Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Quote not closing contextual menu #4443

Merged
merged 2 commits into from Jul 3, 2017

Conversation

@t3chguy
Copy link
Collaborator

t3chguy commented Jun 27, 2017

also use this.closeMenu(); over the explicit direct call as the wrapper exists and is a little clearer

fixes
image

also use `this.closeMenu();` over the explicit direct call as the wrapper exists and is a little clearer
@t3chguy t3chguy force-pushed the t3chguy/patch-3 branch 2 times, most recently from a18cc1c to f36c1ca Jun 29, 2017
@t3chguy

This comment has been minimized.

Copy link
Collaborator Author

t3chguy commented Jun 29, 2017

I'm going to try the arbitrary thing of cherry-picking this onto a fresh branch to see whether that cheers Travis up
...
did not work.

@lukebarnard1

This comment has been minimized.

Copy link
Contributor

lukebarnard1 commented Jun 29, 2017

I've restarted the builds 🙏

@lukebarnard1 lukebarnard1 merged commit cb17cb0 into develop Jul 3, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@t3chguy t3chguy deleted the t3chguy/patch-3 branch Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.