Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use chrome headless instead of phantomjs #4512

Merged
merged 5 commits into from Jul 5, 2017

Conversation

@richvdh
Copy link
Member

richvdh commented Jul 5, 2017

PhantomJS is creaky, and it turns out to be surprisingly easy just to use Chrome in headless mode.

richvdh added 3 commits Jul 5, 2017
Copy link
Member

dbkr left a comment

Thank you!

Only thing I would say is that npm run test now depends on having a chrome available, which will not be the case in general. The only other option is using phantomjs by default and overriding it to chrome headless on travis. I'm inclined to think just depending on chrome is the lesser evil. Maybe we should put a note in the readme?

@richvdh

This comment has been minimized.

Copy link
Member Author

richvdh commented Jul 5, 2017

Yeah, I'm not keen on keeping support for PhantomJS around.

I'll add something to the readme about running the tests.

richvdh added 2 commits Jul 5, 2017
@dbkr
dbkr approved these changes Jul 5, 2017
@richvdh richvdh merged commit 43a70c2 into develop Jul 5, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@richvdh richvdh deleted the rav/chrome_headless branch Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.