Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give HomePage an unmounted guard #4556

Merged
merged 2 commits into from Jul 11, 2017

Conversation

@richvdh
Copy link
Member

richvdh commented Jul 11, 2017

Also add missing return in error-handling path

Also add missing return in error-handling path
Copy link
Contributor

lukebarnard1 left a comment

LGTM apart from probable _t

if (this._unmounted) {
return;
}

if (err || response.status < 200 || response.status >= 300) {
console.log(err);
this.setState({ page: "Couldn't load home page" });

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 Jul 11, 2017

Contributor

I wonder if we should _t this?

This comment has been minimized.

Copy link
@richvdh

richvdh Jul 11, 2017

Author Member

probably, but that sounds like a separate problem

@richvdh richvdh merged commit d25b441 into develop Jul 11, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@richvdh richvdh deleted the rav/homepage_unmounted_guard branch Jul 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.