Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loading tests: wait for login component #4564

Merged
merged 2 commits into from Jul 13, 2017

Conversation

@richvdh
Copy link
Member

richvdh commented Jul 12, 2017

Rather than a fixed delay, use matrix-react-test-utils to wait for the
login component to appear. Hopefully this will deflakify some tests.

richvdh added 2 commits Jul 12, 2017
I don't really know why we disable colours here.
Rather than a fixed delay, use matrix-react-test-utils to wait for the login
component to appear. Hopefully this will deflakify some tests.
@richvdh

This comment has been minimized.

Copy link
Member Author

richvdh commented Jul 12, 2017

I think this is mostly failing because matrix-org/matrix-react-test-utils#2 is missing. Let's land it and see if this starts passing.

@lukebarnard1 lukebarnard1 merged commit a303e1e into develop Jul 13, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@richvdh richvdh deleted the rav/await_login_component branch Jul 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.