Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some adjustments to mx_UserPill and mx_RoomPill #4597

Merged
merged 2 commits into from Jul 19, 2017

Conversation

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Jul 17, 2017

So that they can appear correctly in the body of a text message.

2017-07-19-110426_777x100_scrot
2017-07-19-094706_784x426_scrot

So that they can appear correctly in the body of a text message.
lukebarnard1 added a commit to matrix-org/matrix-react-sdk that referenced this pull request Jul 17, 2017
@dbkr
dbkr approved these changes Jul 17, 2017
@dbkr dbkr assigned lukebarnard1 and unassigned dbkr Jul 17, 2017
@lukebarnard1

This comment has been minimized.

Copy link
Contributor Author

lukebarnard1 commented Jul 19, 2017

I'm going to have to change this so that it matches the design - user pills should not have a background colour in the timeline.

@lukebarnard1 lukebarnard1 assigned dbkr and unassigned lukebarnard1 Jul 19, 2017
@dbkr

This comment has been minimized.

Copy link
Member

dbkr commented Jul 19, 2017

yep, seems reasonable

@lukebarnard1

This comment has been minimized.

Copy link
Contributor Author

lukebarnard1 commented Jul 19, 2017

Given this is just a CSS change, I'm assuming the failing react-sdk test is unrelated (https://travis-ci.org/vector-im/riot-web/jobs/255197083 <-- @richvdh)

@lukebarnard1 lukebarnard1 merged commit f7d282f into develop Jul 19, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.