Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS for group edit UI #4608

Merged
merged 8 commits into from Jul 25, 2017

Conversation

@dbkr
Copy link
Member

dbkr commented Jul 17, 2017

Adds CSS for the edit mode of GroupView

dbkr added 4 commits Jul 13, 2017
@lukebarnard1

This comment has been minimized.

Copy link
Contributor

lukebarnard1 commented Jul 18, 2017

I shall wait until we're happy with matrix-org/matrix-react-sdk#1229 before reviewing

@dbkr dbkr referenced this pull request Jul 21, 2017
Copy link
Contributor

lukebarnard1 left a comment

LGTM otherwise

font-size: 22px;
padding-left: 19px;
padding-right: 16px;
/* why isn't text-overflow working? */

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 Jul 25, 2017

Contributor

You actually need a bunch of things for this to ever work:

 overflow: hidden;
 white-space: nowrap;
 text-overflow: ellipsis;
@lukebarnard1 lukebarnard1 assigned dbkr and unassigned lukebarnard1 Jul 25, 2017
@dbkr dbkr merged commit ec6efd2 into develop Jul 25, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.