Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

un-i18n Modal Analytics #4688

Merged
merged 4 commits into from Aug 10, 2017

Conversation

@t3chguy
Copy link
Collaborator

t3chguy commented Jul 27, 2017

Signed-off-by: Michael Telatynski 7t3chguy@gmail.com

paired with matrix-org/matrix-react-sdk#1255

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy

This comment has been minimized.

Copy link
Collaborator Author

t3chguy commented Jul 27, 2017

Await Manual Testing

Did not exhaustively test but did not find anything immediately wrong upon testing

@t3chguy t3chguy referenced this pull request Jul 27, 2017
t3chguy added 2 commits Jul 28, 2017
…i18n_analytics
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Copy link
Contributor

lukebarnard1 left a comment

You've missed a few errors being tracked

title: _t('Room not found'),
description: _t('Couldn\'t find a matching Matrix room'),
});
}
}, (e) => {
const ErrorDialog = sdk.getComponent("dialogs.ErrorDialog");
Modal.createDialog(ErrorDialog, {
Modal.createTrackedDialog('Fetching third party location failed', e.toString(), ErrorDialog, {

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 Aug 10, 2017

Contributor

e.toString()

@@ -99,7 +99,7 @@ module.exports = React.createClass({
const ErrorDialog = sdk.getComponent("dialogs.ErrorDialog");
// display error message stating you couldn't delete this.
const code = e.errcode || e.statusCode;
Modal.createDialog(ErrorDialog, {
Modal.createTrackedDialog('You cannot delete this message', e.toString(), ErrorDialog, {

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 Aug 10, 2017

Contributor

e.toString()

@@ -76,7 +76,7 @@ module.exports = React.createClass({
var ErrorDialog = sdk.getComponent("dialogs.ErrorDialog");
// display error message stating you couldn't delete this.
var code = e.errcode || e.statusCode;
Modal.createDialog(ErrorDialog, {
Modal.createTrackedDialog('You cannot delete this image.', e.toString(), ErrorDialog, {

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 Aug 10, 2017

Contributor

e.toString()

@@ -131,7 +131,7 @@ module.exports = React.createClass({
this._refreshFromServer();
}, (error) => {
var ErrorDialog = sdk.getComponent("dialogs.ErrorDialog");
Modal.createDialog(ErrorDialog, {
Modal.createTrackedDialog('Error saving email notification preferences', error.toString(), ErrorDialog, {

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 Aug 10, 2017

Contributor

e.toString()

@@ -241,7 +241,7 @@ module.exports = React.createClass({
}, function(error) {
var ErrorDialog = sdk.getComponent("dialogs.ErrorDialog");
console.error("Failed to change settings: " + error);
Modal.createDialog(ErrorDialog, {
Modal.createTrackedDialog('Failed to change settings', error.toString(), ErrorDialog, {

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 Aug 10, 2017

Contributor

e.toString()

@@ -311,7 +311,7 @@ module.exports = React.createClass({
}, function(error) {
var ErrorDialog = sdk.getComponent("dialogs.ErrorDialog");
console.error("Can't update user notification settings: " + error);
Modal.createDialog(ErrorDialog, {
Modal.createTrackedDialog('Can\'t update user notifcation settings', error.toString(), ErrorDialog, {

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 Aug 10, 2017

Contributor

e.toString()

@@ -353,7 +353,7 @@ module.exports = React.createClass({
var onError = function(error) {
var ErrorDialog = sdk.getComponent("dialogs.ErrorDialog");
console.error("Failed to update keywords: " + error);
Modal.createDialog(ErrorDialog, {
Modal.createTrackedDialog('Failed to update keywords', error.toString(), ErrorDialog, {

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 Aug 10, 2017

Contributor

e.toString()

@lukebarnard1 lukebarnard1 assigned t3chguy and unassigned lukebarnard1 Aug 10, 2017
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy assigned lukebarnard1 and unassigned t3chguy Aug 10, 2017
@t3chguy

This comment has been minimized.

Copy link
Collaborator Author

t3chguy commented Aug 10, 2017

@lukebarnard1 lukebarnard1 merged commit 535e335 into develop Aug 10, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@t3chguy t3chguy deleted the t3chguy/i18n_analytics branch Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.