Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crypto on develop #4754

merged 3 commits into from Aug 8, 2017


Copy link

richvdh commented Aug 8, 2017

Fix build scripts so that crypto works on /develop again. Hopefully.

@richvdh richvdh requested a review from lukebarnard1 Aug 8, 2017
richvdh added 3 commits Aug 8, 2017
Pass `--bail` to webpack, so that if we can't find a module, we bail out rather
than deploy a broken version to /develop.

webpack/webpack#708 is somewhat relevant.
do `npm i` in react-sdk *before* symlinking js-sdk, to avoid moving a load of
deps from js-sdk to react-sdk and hence breaking the build.
@richvdh richvdh force-pushed the rav/fix_crypto_build branch from 69b9230 to c31f66a Aug 8, 2017
@richvdh richvdh merged commit 10ee9f4 into develop Aug 8, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
@richvdh richvdh deleted the rav/fix_crypto_build branch Aug 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.