Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove userId property on RightPanel #4775

Merged
merged 2 commits into from Aug 11, 2017

Conversation

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Aug 10, 2017

because we shouldn't have a dispatch AND have a property that do vaguely similar things. Ideally, the dispatch would send a userId and RP would do async work to get the member/avatar/displayname.

because we shouldn't have a dispatch AND have a property that do vaguely similar things. Ideally, the dispatch would send a userId and RP would do async work to get the member/avatar/displayname.
@@ -31,7 +31,6 @@ module.exports = React.createClass({
displayName: 'RightPanel',

propTypes: {
userId: React.PropTypes.string, // if showing an orphaned MemberInfo page, this is set

This comment has been minimized.

Copy link
@dbkr

dbkr Aug 10, 2017

Member

Presumably the long term plan here to do the same for roomId, in which case we should add a comment or else someone will change it back to using props again.

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 Aug 10, 2017

Author Contributor

I don't think so given that the file panel and member list take the room as a prop. I suppose the RightPanel could listen to view_room instead of accepting roomID as a prop?

This comment has been minimized.

Copy link
@dbkr

dbkr Aug 10, 2017

Member

Yeah, I'm assuming we'd be consistent and eventually move to using dispatches everywhere.

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 Aug 10, 2017

Author Contributor

oh I mean it should really listen to the RVS like everything else. I shall comment

@dbkr dbkr assigned lukebarnard1 and unassigned dbkr and lukebarnard1 Aug 10, 2017
@lukebarnard1 lukebarnard1 assigned dbkr and unassigned lukebarnard1 Aug 10, 2017
@dbkr
dbkr approved these changes Aug 11, 2017
@dbkr dbkr merged commit 3eeabe8 into develop Aug 11, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.